Abstract Objective To assess the prevalence of diabetes and its risk factors. Design Population based, cross sectional study. Setting 31 provinces in mainland China with nationally representative cross sectional data from 2015 to 2017. Participants 75 880 participants aged 18 and older—a nationally representative sample of the mainland Chinese population. Main outcome measures Prevalence of diabetes among adults living in China, and the prevalence by sex, regions, and ethnic groups, estimated by the 2018 American Diabetes Association (ADA) and the World Health Organization diagnostic criteria. Demographic characteristics, lifestyle, and history of disease were recorded by participants on a questionnaire. Anthropometric and clinical assessments were made of serum concentrations of fasting plasma glucose (one measurement), two hour plasma glucose, and glycated haemoglobin (HbA 1c ). Results The weighted prevalence of total diabetes (n=9772), self-reported diabetes (n=4464), newly diagnosed diabetes (n=5308), and prediabetes (n=27 230) diagnosed by the ADA criteria were 12.8% (95% confidence interval 12.0% to 13.6%), 6.0% (5.4% to 6.7%), 6.8% (6.1% to 7.4%), and 35.2% (33.5% to 37.0%), respectively, among adults living in China. The weighted prevalence of total diabetes was higher among adults aged 50 and older and among men. The prevalence of total diabetes in 31 provinces ranged from 6.2% in Guizhou to 19.9% in Inner Mongolia. Han ethnicity had the highest prevalence of diabetes (12.8%) and Hui ethnicity had the lowest (6.3%) among five investigated ethnicities. The weighted prevalence of total diabetes (n=8385) using the WHO criteria was 11.2% (95% confidence interval 10.5% to 11.9%). Conclusion The prevalence of diabetes has increased slightly from 2007 to 2017 among adults living in China. The findings indicate that diabetes is an important public health problem in China.